pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Marina Polyakova <m.polyakova@postgrespro.ru>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com
Cc: rjuju123@gmail.com
Cc: daniel@manitou-mail.org
Cc: AndrewBille@gmail.com
Cc: michael@paquier.xyz
Subject: Re: ICU for global collation
Date: Sat, 17 Sep 2022 11:42:24 +0300
Message-ID: <355a424f234f849c2515b9c4076feff0@postgrespro.ru> (raw)
In-Reply-To: <26461c69-cbce-c286-1716-41148b5e0f06@enterprisedb.com>
References: <1f86f120-7b02-68f6-a434-132d054afe33@enterprisedb.com>
	<38d2aac40a991b20adf032e509c6eff5@postgrespro.ru>
	<6dd6db0984d86a51b7255ba79f111971@postgrespro.ru>
	<20220915.155210.529619933474389138.horikyota.ntt@gmail.com>
	<2322791a368e9ad066edd648790b5e91@postgrespro.ru>
	<26461c69-cbce-c286-1716-41148b5e0f06@enterprisedb.com>

On 2022-09-16 10:56, Peter Eisentraut wrote:
> On 15.09.22 17:41, Marina Polyakova wrote:
>> I agree with you. Here's another version of the patch. The 
>> locale/encoding checks and reports in initdb have been reordered, 
>> because now the encoding is set first and only then the ICU locale is 
>> checked.
> 
> I committed something based on the first version of your patch.  This
> reordering of the messages here was a little too much surgery for me
> at this point.  For instance, there are also messages in #ifdef WIN32
> code that would need to be reordered as well.  I kept the overall
> structure of the code the same and just inserted the additional
> proposed checks.
> 
> If you want to pursue the reordering of the checks and messages
> overall, a patch for the master branch could be considered.

Thank you! I already wrote about the order of the ICU checks in 
initdb/create database, they were the only reason to propose such 
changes...

-- 
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





view thread (111+ messages)  latest in thread

Message-ID: <355a424f234f849c2515b9c4076feff0@postgrespro.ru>
Permalink:  ../355a424f234f849c2515b9c4076feff0@postgrespro.ru/
Also on:    postgresql.org/message-id/355a424f234f849c2515b9c4076feff0@postgrespro.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: m.polyakova@postgrespro.ru, peter.eisentraut@enterprisedb.com, horikyota.ntt@gmail.com, pryzby@telsasoft.com, rjuju123@gmail.com, daniel@manitou-mail.org, AndrewBille@gmail.com, michael@paquier.xyz
  Subject: Re: ICU for global collation
  In-Reply-To: <355a424f234f849c2515b9c4076feff0@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox