From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Christoph Berg <myon@debian.org>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Date: Wed, 31 Aug 2022 11:35:17 +0200
Message-ID: <357fec80-cb54-1455-0632-b23d844e5a68@enterprisedb.com> (raw)
In-Reply-To: <Yw4Noe3A2s87A0qq@msg.df7cb.de>
References: <Yw4Noe3A2s87A0qq@msg.df7cb.de>
On 30.08.22 15:16, Christoph Berg wrote:
> I found the list of TG_ variables on
> https://www.postgresql.org/docs/current/plpgsql-trigger.html#PLPGSQL-DML-TRIGGER
> hard to read for several reasons: too much whitespace, all the lines
> start with "Data type", and even after that, the actual content is
> hiding behind some extra "variable that..." boilerplate.
>
> The attached patch formats the list as a table, and removes some of
> the clutter from the text.
>
> I reused the catalog_table_entry table machinery, that is probably not
> quite the correct thing, but I didn't find a better variant, and the
> result looks ok.
I find the new version even harder to read. The catalog_table_entry
stuff doesn't really make sense here, since what you have before is
already a definition list, and afterwards you have the same, just marked
up "incorrectly".
We could move the data type in the <term>, similar to how you did it in
your patch.
I agree the whitespace layout is weird, but that's a problem of the
website CSS stylesheet. I think it looks a bit better with the local
stylesheet, but that can all be tweaked.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, myon@debian.org, pgsql-hackers@lists.postgresql.org
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
In-Reply-To: <357fec80-cb54-1455-0632-b23d844e5a68@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox