From: anarazel@anarazel.de <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Subject: Re: Command Triggers, patch v11
Date: Tue, 28 Feb 2012 01:29:20 +0100
Message-ID: <35d4fa81-9f08-49ec-a09b-5ce1b3ab1035@email.android.com> (raw)
In-Reply-To: <22328.1330388498@sss.pgh.pa.us>
References: <m24nufq466.fsf@2ndQuadrant.fr>
<CAA-aLv67=BeqLr3CukJSm2q7ZhbDnt5aiJwKDBXcyNg5g1JUug@mail.gmail.com>
<201202272037.25322.andres@anarazel.de>
<201202280032.27171.andres@anarazel.de>
<22328.1330388498@sss.pgh.pa.us>
Tom Lane <tgl@sss.pgh.pa.us> schrieb:
>Andres Freund <andres@anarazel.de> writes:
>> I refreshed the patch so it works again on current HEAD. Basically
>some
>> trivial fixes and dfd26f9c5f371437f243249025863ea9911aacaa. The
>latter doesn't
>> seem necessary to me after the changes, so I simply ditched it. Am I
>missing
>> something?
>
>No, that was only needed because execMain.c was overriding somebody
>else's tuple receiver. If you're putting the right receiver into the
>QueryDesc to start with, it shouldn't be necessary.
>
>I'm confused by this though:
>
>> This basically includes a revert of
>d8fb1f9adbddd1eef123d66a89a9fc0ecd96f60b
>
>I don't find that commit ID anywhere.
That should have been the aforementioned commit. Must have screwed up the copy&paste buffer. Sorry for that.
Andres
Please excuse the brevity and formatting - I am writing this on my mobile phone.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, thom@linux.com, dimitri@2ndquadrant.fr
Subject: Re: Command Triggers, patch v11
In-Reply-To: <35d4fa81-9f08-49ec-a09b-5ce1b3ab1035@email.android.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox