From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bernd Helmle <mailings@oopsware.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Japin Li <japinli@hotmail.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: Modern SHA2- based password hashes for pgcrypto
Date: Mon, 07 Apr 2025 14:16:55 -0400
Message-ID: <3601727.1744049815@sss.pgh.pa.us> (raw)
In-Reply-To: <3532284.1744048235@sss.pgh.pa.us>
References: <202504051722.3jv3ashzaibd@alvherre.pgsql>
<2977905.1743968616@sss.pgh.pa.us>
<6fab35422df6b6b9727fdcc243c5fa1c667dd3b5.camel@oopsware.de>
<3532284.1744048235@sss.pgh.pa.us>
I wrote:
> Bernd Helmle <mailings@oopsware.de> writes:
>> Here is a patch that tries to address all these issues (including
>> Andres' report). I've adjusted the error message and use ereport(), so
>> it might be more useful if we deal with not just single byte letters.
> I'd like to get mamba back to green, so I'll take care of this
And done. FYI, we actually have a standard practice for error
messages that want to complain about a single character without
assuming it's a single-byte character:
ereport(ERROR,
errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("invalid character in salt string: \"%.*s\"",
pg_mblen(ep), ep));
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, mailings@oopsware.de, alvherre@alvh.no-ip.org, andres@anarazel.de, japinli@hotmail.com
Subject: Re: Modern SHA2- based password hashes for pgcrypto
In-Reply-To: <3601727.1744049815@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox