From: Tom Lane <tgl@sss.pgh.pa.us>
To: vignesh C <vignesh21@gmail.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: sequencesync worker race with REFRESH SEQUENCES
Date: Wed, 15 Jul 2026 22:58:28 -0400
Message-ID: <3621808.1784170708@sss.pgh.pa.us> (raw)
In-Reply-To: <CALDaNm2myhhkoctERWc2x9xA2N3eJojk9h-mAPi-oXatq+ivMA@mail.gmail.com>
References: <20260710045217.f0.noahmisch@microsoft.com>
<CAA4eK1K8LD243UzHgVNCm4skJZ4UCjR3vowDhKp=cWnK5oBT-Q@mail.gmail.com>
<20260715025809.cd.noahmisch@microsoft.com>
<CAA4eK1+k+iKhNtt6bq2SJQm+K_ZYUrS5GCqnf6a6qK6_DrX5Gg@mail.gmail.com>
<20260715115601.fd.noahmisch@microsoft.com>
<3614163.1784163070@sss.pgh.pa.us>
<CALDaNm2myhhkoctERWc2x9xA2N3eJojk9h-mAPi-oXatq+ivMA@mail.gmail.com>
vignesh C <vignesh21@gmail.com> writes:
> On Thu, 16 Jul 2026 at 06:21, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That is, after checking for the "insufficient privileges" case,
>> we aren't waiting long enough for the new seqsync worker to quiesce.
>> This wasn't a problem before f38afa4ab, because it wasn't an error
>> condition for that worker to still be running.
> I think we can simply remove the REFRESH SEQUENCES command and add a
> comment explaining that the sequence synchronization worker is
> restarted automatically while there are sequences that are not yet in
> the READY state.
Well, that would fix this test, but I wonder if this result isn't
telling us that f38afa4ab has created a failure condition that will
bite real users. Why would the user issuing REFRESH SEQUENCES be
aware of whether there's a sync worker running right then? Why
should it be his problem to avoid that?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, vignesh21@gmail.com, noah@leadboat.com, amit.kapila16@gmail.com
Subject: Re: sequencesync worker race with REFRESH SEQUENCES
In-Reply-To: <3621808.1784170708@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox