From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Nikolay Shaplov <dhyan@nataraj.su>
To: pgsql-hackers@lists.postgresql.org
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [PATCH] check for ctags utility in make_ctags
Date: Thu, 3 Jan 2019 12:52:36 +0100
Message-ID: <364f4cb7-4f1f-516e-d27e-59578b7cf18c@2ndquadrant.com> (raw)
In-Reply-To: <2205856.meAnofT0VS@x200m>
References: <2394207.ccz7JgCJsh@x200m>
<4273.1546446946@sss.pgh.pa.us>
<20190103010353.GA1442@paquier.xyz>
<2205856.meAnofT0VS@x200m>
On 03/01/2019 12:15, Nikolay Shaplov wrote:
>> +1, let's keep it simple. I would just use "ctags/etags not found"
>> as error message.
>
> Actually I was trying to say "Please install 'ctags' [utility] to run
> make_ctags". But if all of you read it as "Please install 'ctags' [package] to
> run make_ctags", then it is really better to drop the advice.
>
> So I removed it. See the patch.
A few more comments.
I don't know how portable command -v is. Some systems have a /bin/sh
that is pre-POSIX. Same with $(...).
If etags is not installed, the current script prints
xargs: etags: No such file or directory
I don't see the need to do more than that, especially if it makes the
script twice as long.
(Personally, I'd recommend removing make_etags altogether and using GNU
Global for Emacs.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, dhyan@nataraj.su, pgsql-hackers@lists.postgresql.org, michael@paquier.xyz, tgl@sss.pgh.pa.us
Subject: Re: [PATCH] check for ctags utility in make_ctags
In-Reply-To: <364f4cb7-4f1f-516e-d27e-59578b7cf18c@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox