From: torikoshia <torikoshia@oss.nttdata.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Cc: rmt@lists.postgresql.org
Subject: Re: Improve tab completion for COPY
Date: Thu, 03 Jul 2025 22:30:34 +0900
Message-ID: <36924a0353817ec90ab23e424a18b3f3@oss.nttdata.com> (raw)
In-Reply-To: <CAD21AoDCPG2Zn2BscmqQ=TfsBNFokCgQP9_HNnO9zyU98yFZMg@mail.gmail.com>
References: <079e7a2c801f252ae8d522b772790ed7@oss.nttdata.com>
<20250507222318.421a6b6bfc311f4cdf07ebc0@sraoss.co.jp>
<CAD21AoDGvRZiHQoz1V+QQ4E3G9Yhzrq6_Siwi4iGtCmmP1hB2g@mail.gmail.com>
<20250508085335.77b8c480e96f032b87c2d8c3@sraoss.co.jp>
<0988d0a8c87c37ec8cb8d3643d9dc35a@oss.nttdata.com>
<20250603175801.d1fc50eefb178e5ca7312fd1@sraoss.co.jp>
<ac23e824d1d602f113a89c91ee56fb23@oss.nttdata.com>
<20250610115954.fac87b39e5dfb91e32071b10@sraoss.co.jp>
<CAD21AoBXB+bWUJkBnBpPme6j6HgdTtgszi7naho7OCbasEz4Yg@mail.gmail.com>
<aEiWfUt9l-ieeZ2N@nathan>
<CAD21AoA8tuXx5SjP8uCD6My+s2i=Gvfc=r2XF3iHS93JyEO9GQ@mail.gmail.com>
<CAD21AoBcH-itq6VYwaxueJED9PZ=C97cqOTTJqB5ULQ+OFUuWQ@mail.gmail.com>
<de42a2625da90e4e47d4023716e230e0@oss.nttdata.com>
<CAD21AoDCPG2Zn2BscmqQ=TfsBNFokCgQP9_HNnO9zyU98yFZMg@mail.gmail.com>
On 2025-07-03 11:37, Masahiko Sawada wrote:
> On Wed, Jul 2, 2025 at 2:46 PM torikoshia <torikoshia@oss.nttdata.com>
> wrote:
>>
>> On 2025-07-01 14:20, Masahiko Sawada wrote:
>> > On Thu, Jun 12, 2025 at 3:47 AM Masahiko Sawada <sawada.mshk@gmail.com>
>> > wrote:
>> >>
>> >> On Tue, Jun 10, 2025 at 1:33 PM Nathan Bossart
>> >> <nathandbossart@gmail.com> wrote:
>> >> >
>> >> > On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote:
>> >> > >> > (1) adds tab completion support for the REJECT_LIMIT option, which was
>> >> > >> > introduced in v18
>> >> > >> > (2) splits the tab completion logic between COPY FROM and COPY TO to
>> >> > >> > reflect their different options.
>> >> > >
>> >> > > [...]
>> >> > >
>> >> > > Given REJECT_LIMIT is a new v18 feature, it seems to me that (1) is an
>> >> > > oversight of this feature, but I also agree that it's not a bug and
>> >> > > doesn't block the release.
>> >> > >
>> >> > > How does the RMT feel about the change (1)? Nathan, would you be OK with that?
>> >> >
>> >> > 0001 sure seems like an oversight in commit 4ac2a9b to me. In any case, I
>> >> > argued that we should fix tab completion for unlogged partitioned tables in
>> >> > v18 [0], and this seems pretty similar.
>> >> >
>> >> >
>> >> > TBH I'd even say that 0002 is fixing a bug and could be back-patched. I've
>> >> > added rmt@ here in case Tomas or Heikki feel differently.
>> >>
>> >> Thank you for your confirmation. I've just pushed the change (1) and
>> >> am waiting for more comments on the change (2).
>> >>
>> >
>> > Thinking of the 0002 patch, I'm also inclined to agree that this fixes
>> > a bogus tab completion behavior for COPY command and can be
>> > back-patched to v14. In v14, c273d9d8ce reworked the tab completion
>> > for COPY command and supports the completion for the options of FORMAT
>> > within a WITH clause so we cannot back-patch it to v13.
>>
>> Agreed.
>>
>> > Torikoshi-san, could you please prepare the patch for other branches
>> > too if you agree with this direction?
>>
>> Sure! Attached patches.
>
> Thank you for updating the patches! The patches mostly look good to
> me. As for v3-0002-Improve-tab-completion-for-COPY-options_v17.patch,
> please note that we don't support REJECT_LIMIT in v17:
>
> +/* COPY FROM options */
> +#define Copy_from_options \
> +Copy_common_options, "DEFAULT", "FORCE_NOT_NULL", "FORCE_NULL",
> "FREEZE", \
> +"LOG_VERBOSITY", "ON_ERROR", "REJECT_LIMIT"
Thanks for your check and correction!
> I've attached the updated patches that addressed the above issue and
> updated the commit messages. Please review them.
Other than the fix you mentioned, the changes are the same as in the
v3-0002 patches.
I didn’t find any particular issues.
> Regards,
--
Regards,
--
Atsushi Torikoshi
Seconded from NTT DATA Japan Corporation to SRA OSS K.K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: torikoshia@oss.nttdata.com, sawada.mshk@gmail.com, nathandbossart@gmail.com, nagata@sraoss.co.jp, rmt@lists.postgresql.org
Subject: Re: Improve tab completion for COPY
In-Reply-To: <36924a0353817ec90ab23e424a18b3f3@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox