pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>
Cc: torikoshia <torikoshia@oss.nttdata.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Cc: rmt@lists.postgresql.org
Subject: Re: Improve tab completion for COPY
Date: Tue, 10 Jun 2025 15:33:01 -0500
Message-ID: <aEiWfUt9l-ieeZ2N@nathan> (raw)
In-Reply-To: <CAD21AoBXB+bWUJkBnBpPme6j6HgdTtgszi7naho7OCbasEz4Yg@mail.gmail.com>
References: <079e7a2c801f252ae8d522b772790ed7@oss.nttdata.com>
	<20250507222318.421a6b6bfc311f4cdf07ebc0@sraoss.co.jp>
	<CAD21AoDGvRZiHQoz1V+QQ4E3G9Yhzrq6_Siwi4iGtCmmP1hB2g@mail.gmail.com>
	<20250508085335.77b8c480e96f032b87c2d8c3@sraoss.co.jp>
	<0988d0a8c87c37ec8cb8d3643d9dc35a@oss.nttdata.com>
	<20250603175801.d1fc50eefb178e5ca7312fd1@sraoss.co.jp>
	<ac23e824d1d602f113a89c91ee56fb23@oss.nttdata.com>
	<20250610115954.fac87b39e5dfb91e32071b10@sraoss.co.jp>
	<CAD21AoBXB+bWUJkBnBpPme6j6HgdTtgszi7naho7OCbasEz4Yg@mail.gmail.com>

On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote:
>> > (1) adds tab completion support for the REJECT_LIMIT option, which was
>> > introduced in v18
>> > (2) splits the tab completion logic between COPY FROM and COPY TO to
>> > reflect their different options.
>
> [...]
> 
> Given REJECT_LIMIT is a new v18 feature, it seems to me that (1) is an
> oversight of this feature, but I also agree that it's not a bug and
> doesn't block the release.
> 
> How does the RMT feel about the change (1)?  Nathan, would you be OK with that?

0001 sure seems like an oversight in commit 4ac2a9b to me.  In any case, I
argued that we should fix tab completion for unlogged partitioned tables in
v18 [0], and this seems pretty similar.

TBH I'd even say that 0002 is fixing a bug and could be back-patched.  I've
added rmt@ here in case Tomas or Heikki feel differently.

[0] https://postgr.es/m/aEH4XYwrlyvjZUvE%40nathan

-- 
nathan





view thread (18+ messages)  latest in thread

Message-ID: <aEiWfUt9l-ieeZ2N@nathan>
Permalink:  ../aEiWfUt9l-ieeZ2N@nathan/
Also on:    postgresql.org/message-id/aEiWfUt9l-ieeZ2N@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, sawada.mshk@gmail.com, nagata@sraoss.co.jp, torikoshia@oss.nttdata.com, rmt@lists.postgresql.org
  Subject: Re: Improve tab completion for COPY
  In-Reply-To: <aEiWfUt9l-ieeZ2N@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox