From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Rahila Syed <rahilasyed90@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: monitoring CREATE INDEX [CONCURRENTLY]
Date: Wed, 13 Feb 2019 13:31:53 +0900
Message-ID: <36d781d7-e0f3-e2e9-b4b4-70e0b481a1ed@lab.ntt.co.jp> (raw)
In-Reply-To: <20190212031824.GA14185@alvherre.pgsql>
References: <20190212031824.GA14185@alvherre.pgsql>
Hi Alvaro,
On 2019/02/12 12:18, Alvaro Herrera wrote:
> I ended up defining phases for the index_build phase in the AM itself;
> the code reports a phase number using the regular API, and then the
> pgstat_progress view obtains the name of each phase using a support
> method.
diff --git a/doc/src/sgml/indexam.sgml b/doc/src/sgml/indexam.sgmlindex 05102724ead..189179a5667 100644--- a/doc/src/sgml/indexam.sgml+++ b/doc/src/sgml/indexam.sgml@@ -127,6 +127,7 @@ typedef struct IndexAmRoutine
amcostestimate_function amcostestimate;
amoptions_function amoptions;
amproperty_function amproperty; /* can be NULL */
+ amphasename_function amphasename; /* can be NULL */
Doesn't the name amphasename sound a bit too generic, given that it can
only describe the phases of ambuild? Maybe ambuildphase?
Thanks,
Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: Langote_Amit_f8@lab.ntt.co.jp, alvherre@2ndquadrant.com, rahilasyed90@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: monitoring CREATE INDEX [CONCURRENTLY]
In-Reply-To: <36d781d7-e0f3-e2e9-b4b4-70e0b481a1ed@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox