pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@lists.postgresql.org, Chantal Keller <chantal.keller@universite-paris-saclay.fr>
Subject: Re: Improving EXPLAIN's display of SubPlan nodes
Date: Mon, 18 Mar 2024 20:03:20 -0400
Message-ID: <3717916.1710806600@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEZATCUzo-GnuEy8Y=5tuL=32CQy6JCDF7VxajGpm_cv6HHKjw@mail.gmail.com>
References: <2838538.1705692747@sss.pgh.pa.us>
	<CAJ7c6TMApZ62NOOk73_BmKkKtdhV+i=tyvXR52DAB-YVuFANDA@mail.gmail.com>
	<3791430.1705943243@sss.pgh.pa.us>
	<3831858.1705959108@sss.pgh.pa.us>
	<3511300.1708112330@sss.pgh.pa.us>
	<CAEZATCUQB3ybgBxEHXq28ihMS3+Bq-Gy8RraJpKGmVpjES6E3A@mail.gmail.com>
	<2506269.1710514705@sss.pgh.pa.us>
	<2982030.1710609907@sss.pgh.pa.us>
	<CAEZATCVa63moqwsi37a6LKj9mDsnbzEUw0KJYT8Qe2OZ-7V+Jg@mail.gmail.com>
	<3127158.1710685722@sss.pgh.pa.us>
	<3399753.1710704359@sss.pgh.pa.us>
	<CAEZATCULqMzbME2UEpybnBnp_U_6Yaa2Zm1BFuPFXKUq4-RXhw@mail.gmail.com>
	<3691942.1710796200@sss.pgh.pa.us>
	<3712528.1710803943@sss.pgh.pa.us>
	<CAEZATCUzo-GnuEy8Y=5tuL=32CQy6JCDF7VxajGpm_cv6HHKjw@mail.gmail.com>

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Mon, 18 Mar 2024 at 23:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> After thinking a bit more, I understood what was bothering me about
>> that notation: it looks too much like a call of a user-defined
>> function named "rescan()".  I think we'd be better off with the
>> all-caps "RESCAN()".

> Or perhaps move the parentheses, and write "(rescan SubPlan N)" or
> "(reset SubPlan N)". Dunno.

Oh, I like that!  It seems rather parallel to the existing "hashed"
annotation.  If I had it to do over, I'd likely do the "hashed"
bit differently --- but as the proposal currently stands, we are
not changing "hashed", so we might as well double down on that.

I won't update the patch right now, but "(rescan SubPlan N)"
seems like a winner to me.

			regards, tom lane





view thread (23+ messages)  latest in thread

Message-ID: <3717916.1710806600@sss.pgh.pa.us>
Permalink:  ../3717916.1710806600@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3717916.1710806600@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, aleksander@timescale.com, chantal.keller@universite-paris-saclay.fr
  Subject: Re: Improving EXPLAIN's display of SubPlan nodes
  In-Reply-To: <3717916.1710806600@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox