pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fabrízio de Royes Mello <fabriziomello@gmail.com>
Cc: Dong Wook Lee <sh95119@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add pg_freespacemap extension sql test
Date: Sun, 27 Mar 2022 13:18:46 -0400
Message-ID: <381910.1648401526@sss.pgh.pa.us> (raw)
In-Reply-To: <Yju992Vtd/nhArwL@paquier.xyz>
References: <CAAcByaKWYktP-DdZMZ-NSKiuXK5XtGKTKM5P8ae1EfNF2EKguA@mail.gmail.com>
	<368485.1646756358@sss.pgh.pa.us>
	<CAAcByaLieDjN7ra=T8g2DB_MvO6vmNwOOmtMsPoBzCb7XoSzVw@mail.gmail.com>
	<YirjZxEFY9eq/opN@paquier.xyz>
	<CAAcByaKpSkoJA8v-6FAyZaXEJJHbnBhDhrdDq_c+KXOwwcGehw@mail.gmail.com>
	<CAAcByaJbRkkRkxaGKbvZS-K_Qz3A2TA7TjVVnNQgp74u8zUS=w@mail.gmail.com>
	<CAFcNs+r-jBAE8RQqNqC+W5Li+N6xACVnAGvAFNwoWuAVEqZrDg@mail.gmail.com>
	<CAAcByaLk_Q0VHyBHuTGrV3AGT8z=qasD5pEK6CYJKMbL7iX+zw@mail.gmail.com>
	<Yjq4qwIVrjb2wYa+@paquier.xyz>
	<CAFcNs+r-2R0+XzscJxtHQO3miRTbaqoovLTQkXQ_j_sUO=woGg@mail.gmail.com>
	<Yju992Vtd/nhArwL@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> Yes, we could extend that more.  For now, I am curious to see what the
> buildfarm has to say with the current contents of the patch, and I can
> keep an eye on the buildfarm today, so I have applied it.

It seems this is unstable under valgrind [1]:


inline patch 1: /mnt/resource/bf/build/skink-master/HEAD/pgsql.build/contrib/pg_freespacemap/results/pg_freespacemap.out (+2/-1 lines) download inline-1.patch--- /mnt/resource/bf/build/skink-master/HEAD/pgsql/contrib/pg_freespacemap/expected/pg_freespacemap.out	2022-03-24 09:39:43.974477703 +0000
+++ /mnt/resource/bf/build/skink-master/HEAD/pgsql.build/contrib/pg_freespacemap/results/pg_freespacemap.out	2022-03-27 17:07:23.896287669 +0000
@@ -60,6 +60,7 @@
     ORDER BY 1, 2;
        id        | blkno | is_avail 
 -----------------+-------+----------
+ freespace_tab   |     0 | t
  freespace_brin  |     0 | f
  freespace_brin  |     1 | f
  freespace_brin  |     2 | t
@@ -75,7 +76,7 @@
  freespace_hash  |     7 | f
  freespace_hash  |     8 | f
  freespace_hash  |     9 | f
-(15 rows)
+(16 rows)
 
 -- failures with incorrect block number
 SELECT * FROM pg_freespace('freespace_tab', -1);


skink has passed several runs since the commit went in, so it's
"unstable" not "fails consistently".  I see the test tries to
disable autovacuum on that table, so that doesn't seem to be
the problem ... what is?

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2022-03-27%2008%3A26%3A20





view thread (17+ messages)  latest in thread

Message-ID: <381910.1648401526@sss.pgh.pa.us>
Permalink:  ../381910.1648401526@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/381910.1648401526@sss.pgh.pa.us

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, fabriziomello@gmail.com, sh95119@gmail.com
  Subject: Re: Add pg_freespacemap extension sql test
  In-Reply-To: <381910.1648401526@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox