From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Some regular-expression performance hacking
Date: Tue, 23 Feb 2021 13:22:35 -0500
Message-ID: <3877169.1614104555@sss.pgh.pa.us> (raw)
In-Reply-To: <20210223180535.ebgpwkyem33xtt7d@alap3.anarazel.de>
References: <1340281.1613018383@sss.pgh.pa.us>
<20210223173437.b3ywijygsy6q42gq@alap3.anarazel.de>
<3874948.1614101949@sss.pgh.pa.us>
<3875615.1614102748@sss.pgh.pa.us>
<20210223180535.ebgpwkyem33xtt7d@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2021-02-23 12:52:28 -0500, Tom Lane wrote:
>> ... It is annoying to have to expend
>> an always-on check for a can't-happen case, though.
> Wouldn't quite work like that because of the restrictions of what pg
> infrastructure we want to expose the regex engine to, but a
> if (depth < 0)
> pg_unreachable();
> would avoid the runtime overhead and does fix the warning.
Yeah, I still have dreams of someday converting the regex engine
into an independent project, so I don't want to make it depend on
pg_unreachable. I'll put in the low-tech fix.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Some regular-expression performance hacking
In-Reply-To: <3877169.1614104555@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox