pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Gregory Stark (as CFM) <stark.cfm@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Surafel Temesgen <surafel3000@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: proposal: possibility to read dumped table's name from file
Date: Wed, 29 Nov 2023 22:39:46 -0500
Message-ID: <388186.1701315586@sss.pgh.pa.us> (raw)
In-Reply-To: <6714E9BB-9EA3-486A-B7AC-976D97301F61@yesql.se>
References: <CAFj8pRBmN1AGm7wBk8279_mf-vCd6vaiY+tJ=dOLrn9p1LAL8w@mail.gmail.com>
	<CAFj8pRAGiNnOUEE5zf3yD60Y82qyLB_ehC=rUNPks0FHULR+oQ@mail.gmail.com>
	<ZBcVz5Gymrv23Ntu@telsasoft.com>
	<CAFj8pRDN8_jqzk8SppfYLeXw02XeNf_zYO28ZjjPf1hcQFe30g@mail.gmail.com>
	<ZBnN9x71hH8F/LQv@telsasoft.com>
	<CAFj8pRBqpMvqTLftpte5cQWa=8-Hd6nSZ6PiyXgRvRXu1-N_Ow@mail.gmail.com>
	<CAFj8pRA25Kg1_skQKic1cyLThrNuwY+uDU4ozuCsm2JthmdLdw@mail.gmail.com>
	<CAFj8pRAHQb0CBh33rrJUc67f+2Meug8NqWa1Qfv8CaDCzQ+CCQ@mail.gmail.com>
	<CAFj8pRAKFoPSg392t_Mc1612H7icdf2cKXt_vtzObtyK=PwaNw@mail.gmail.com>
	<70FC9210-B636-4863-9138-B126176D6BE2@yesql.se>
	<CAFj8pRA4LebAbgT-VyhJbrZzzVJ2d8p5K1vBrzJuxWBKeHa8iw@mail.gmail.com>
	<CAFj8pRAZ8DNZY_Wevp7JvD+vw3B87E=B39qkKuXUG9tUCzyDAg@mail.gmail.com>
	<87B9339B-3492-465A-AD06-F4DDE918696D@yesql.se>
	<CAFj8pRB7yGMO+s5U=40HWbS3GEaMw554mJzAhiTjKuky90vRzQ@mail.gmail.com>
	<CAFj8pRD_yAue_M2WPMAU1jw2_ONyAGaTwsD1CyFTrwmFYo6Zvw@mail.gmail.com>
	<A7D7ED17-A2FD-43D7-94B1-8E354B6F22A8@yesql.se>
	<8186e8f! 0-fc8b-3d67-5e9d-c1e3e8e26040@xs4all.nl>
	<6714E9BB-9EA3-486A-B7AC-976D97301F61@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
> I took another look at this, found some more polish that was needed, added
> another testcase and ended up pushing it.

mamba is unhappy because this uses <ctype.h> functions without
casting their arguments to unsigned char:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mamba&dt=2023-11-30%2002%3A53%3A25

(I had not realized that we still had buildfarm animals that would
complain about this ... but I'm glad we do, because it's a hazard.
POSIX is quite clear that the behavior is undefined for signed chars.)

			regards, tom lane





view thread (203+ messages)  latest in thread

Message-ID: <388186.1701315586@sss.pgh.pa.us>
Permalink:  ../388186.1701315586@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/388186.1701315586@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, er@xs4all.nl, pavel.stehule@gmail.com, pryzby@telsasoft.com, rjuju123@gmail.com, stark.cfm@gmail.com, andres@anarazel.de, andrew@dunslane.net, alvherre@2ndquadrant.com, tomas.vondra@enterprisedb.com, dean.a.rasheed@gmail.com, sfrost@snowman.net, surafel3000@gmail.com, vignesh21@gmail.com
  Subject: Re: proposal: possibility to read dumped table's name from file
  In-Reply-To: <388186.1701315586@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox