From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Making C function declaration parameter names consistent with corresponding definition names
Date: Fri, 16 Sep 2022 19:19:51 -0400
Message-ID: <3913123.1663370391@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com>
References: <CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com>
Peter Geoghegan <pg@bowt.ie> writes:
> I have to admit that these inconsistencies are a pet peeve of mine. I
> find them distracting, and have a history of fixing them on an ad-hoc
> basis. But there are real practical arguments in favor of being strict
> about it as a matter of policy -- it's not *just* neatnikism.
I agree, this has always been a pet peeve of mine as well. I would
have guessed there were fewer examples than you found, because I've
generally fixed any such cases I happened to notice.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-hackers@lists.postgresql.org
Subject: Re: Making C function declaration parameter names consistent with corresponding definition names
In-Reply-To: <3913123.1663370391@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox