pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Drouvot, Bertrand <bdrouvot@amazon.com>
Subject: Re: Generating code for query jumbling through gen_node_support.pl
Date: Thu, 09 Feb 2023 18:12:50 -0500
Message-ID: <3972105.1675984370@sss.pgh.pa.us> (raw)
In-Reply-To: <Y+V4iQgI0DKi8pnE@paquier.xyz>
References: <e4d61d52-4992-d190-b5ad-48c6c752942c@enterprisedb.com>
	<Y8tdmPlzFyNcrPR3@paquier.xyz>
	<bf604c8d-b6e9-284b-327a-cac8417a74e8@enterprisedb.com>
	<Y8+BdCOjxykre5es@paquier.xyz>
	<9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com>
	<Y9M+C2obzgRnXPNd@paquier.xyz>
	<268fd337-8bb7-92e6-0da2-416c022c11f3@enterprisedb.com>
	<Y9i3+PdW+REPD2oE@paquier.xyz>
	<3344827.1675809127@sss.pgh.pa.us>
	<Y+NFl6N1QWb4ftUy@paquier.xyz>
	<Y+V4iQgI0DKi8pnE@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> Tom, did you get a chance to look at what is proposed here and expand
> the use of query_jumble_ignore in the definitions of the nodes rather
> than have an enforced per-file policy in gen_node_support.pl?

Sorry, didn't look at it before.

I'm okay with the pathnodes.h changes --- although surely you don't need
changes like this:

-	pg_node_attr(abstract)
+	pg_node_attr(abstract, no_query_jumble)

"abstract" should already imply "no_query_jumble".

I wonder too if you could shorten the changes by making no_query_jumble
an inheritable attribute, and then just applying it to Path and Plan.

The changes in parsenodes.h seem wrong, except for RawStmt.  Those node
types are used in parsed queries, aren't they?

			regards, tom lane





view thread (44+ messages)  latest in thread

Message-ID: <3972105.1675984370@sss.pgh.pa.us>
Permalink:  ../3972105.1675984370@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3972105.1675984370@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org, bdrouvot@amazon.com
  Subject: Re: Generating code for query jumbling through gen_node_support.pl
  In-Reply-To: <3972105.1675984370@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox