From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Importing pg_bsd_indent into our source tree
Date: Thu, 09 Feb 2023 18:19:06 -0500
Message-ID: <3972584.1675984746@sss.pgh.pa.us> (raw)
In-Reply-To: <20230209231013.gjpxs4gapxjatc64@awork3.anarazel.de>
References: <3935719.1675967430@sss.pgh.pa.us>
<20230209210202.t6n35jaiuw6nl4dk@awork3.anarazel.de>
<20230209215532.oomwhj5jyggmciq7@awork3.anarazel.de>
<20230209221450.bkuozhhzlgpupx4d@awork3.anarazel.de>
<3966340.1675981162@sss.pgh.pa.us>
<20230209231013.gjpxs4gapxjatc64@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
>> Hmmm .. a shell script would be fine by me, but it won't help in
>> testing a Windows build. Maybe we need to make it a Perl script?
> At least for casual testing a shell script actually mostly works, due to git
> it's easy enough to have a sh.exe around... Not something I'd necessarily want
> to make a hard dependency, but for something like this it might suffice. Of
> course perl would be more dependable...
Yeah, also less question about whether it works on Windows.
I'll see about moving that into Perl. It's short enough.
>> BTW, the attachments to your previous message are identical to what
>> I previously posted --- did you attach the wrong set of diffs?
> I attached an extra patch, in addition to yours.
D'oh, I didn't notice that :-(
> I also attached yours so that
> cfbot could continue to work, if you registered this.
I thought about registering it, but that won't teach us anything unless
we make it built-by-default, which was not my intention. I guess we
could temporarily include it in the build.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Importing pg_bsd_indent into our source tree
In-Reply-To: <3972584.1675984746@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox