pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David E. Wheeler <david@kineticode.com>
To: Heikki Linnakangas <heikki@enterprisedb.com>
Cc: Greg Smith <gsmith@gregsmith.com>
Cc: Aidan Van Dyk <aidan@highrise.ca>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Overhauling GUCS
Date: Fri, 6 Jun 2008 09:22:39 -0700
Message-ID: <3D652D3F-4642-4DC6-B883-E09240F196CE@kineticode.com> (raw)
In-Reply-To: <4848D447.10005@enterprisedb.com>
References: <Pine.GSO.4.64.0806041045520.2258@westnet.com>
	<29525.1212613052@sss.pgh.pa.us>
	<48472E47.7030701@dunslane.net>
	<Pine.GSO.4.64.0806042033120.3874@westnet.com>
	<20080605162400.GF16502@alvh.no-ip.org>
	<48481CBF.6040602@enterprisedb.com>
	<48481E3A.4010306@hagander.net>
	<Pine.GSO.4.64.0806051321360.27711@westnet.com>
	<20080605174209.GL16502@alvh.no-ip.org>
	<Pine.GSO.4.64.0806051452480.27254@westnet.com>
	<20080605212129.GI14498@yugib.highrise.ca>
	<Pine.GSO.4.64.0806051725550.10475@westnet.com>
	<3F927D52-A0FD-4575-8D24-F0F70C459235@kineticode.com>
	<4848D447.10005@enterprisedb.com>

On Jun 5, 2008, at 23:08, Heikki Linnakangas wrote:

> What comments do we consider machine-generated? Just the ones used  
> to comment out settings, like
>
> #shared_buffers = 32MB
>
> or something else?

Those and documentation comments.

> If the automatic tool lets alone all other kind of comments, I think  
> we're fine. In fact, it wouldn't necessarily need to modify those  
> comments either, it could simply add a new setting line below that:
>
> #shared_buffers = 32MB
> shared_buffers = 1024MB

Well, we've been talking about having varying levels of documentation  
in the comments of the file based on the options passed to the  
configuration program. I think that these are the primary concern,  
though Greg, please do correct me if I'm mistaken.

> For extra safety, it could comment out old settings, perhaps with  
> something like this:
>
> #shared_buffers = 32MB
> #shared_buffers = 1024MB  # commented out by wizard on 2008-06-05
> shared_buffers = 2048MB
>
> This would preserve a full change history in the file. It would  
> become quite messy after a lo of changes, of course, but a user can  
> trim the history by hand if he wants to.

I guess that could be a feature. Personally, I use a vcs system for  
that.

Best,

David



view thread (226+ messages)  latest in thread

Message-ID: <3D652D3F-4642-4DC6-B883-E09240F196CE@kineticode.com>
Permalink:  ../3D652D3F-4642-4DC6-B883-E09240F196CE@kineticode.com/
Also on:    postgresql.org/message-id/3D652D3F-4642-4DC6-B883-E09240F196CE@kineticode.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@kineticode.com, heikki@enterprisedb.com, gsmith@gregsmith.com, aidan@highrise.ca
  Subject: Re: Overhauling GUCS
  In-Reply-To: <3D652D3F-4642-4DC6-B883-E09240F196CE@kineticode.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox