public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Chao Li <[email protected]>
Cc: Steven Niu <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: remove obsolete comment in AtEOXact_Inval
Date: Fri, 8 May 2026 10:54:22 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <MN2PR15MB30219837B2381AE2518A4C45A7FCA@MN2PR15MB3021.namprd15.prod.outlook.com>
	<[email protected]>

> On 27 Oct 2025, at 04:50, Chao Li <[email protected]> wrote:
> 
>> On Oct 27, 2025, at 10:43, Steven Niu <[email protected]> wrote:
>> 
>> Hi, Hackers,
>> 
>> When I read the code, I noticed there is one line of comment in function AtEOXact_Inval() which is obviously obsolete.
>> 
>>    "This should be called as the last step in processing a transaction"  
>> 
>> Steven<0001-PATCH-remove-obsolete-comment-in-AtEOXact_Inval.patch>
> 
> +1
> 
> The comment of "void AtEOXact_Inval(bool isCommit):
> ```
> * Note:
> * This should be called as the last step in processing a transaction.
> ```
> Was added 29 years ago.

This comment was part of the Postgres95 import, and was originally added to the
function RegisterInvalid() which in turn was committed by Cimarron Taylor in
1990.  I agree that it's no longer helpful and will go ahead to remove it shortly
unless someone disagrees.

--
Daniel Gustafsson

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: remove obsolete comment in AtEOXact_Inval
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox