From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade generated files in subdir follow-up
Date: Wed, 31 Aug 2022 09:59:27 -0400
Message-ID: <4061927.1661954367@sss.pgh.pa.us> (raw)
In-Reply-To: <181A6DA8-3B7F-4B71-82D5-363FF0146820@yesql.se>
References: <181A6DA8-3B7F-4B71-82D5-363FF0146820@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> Commit 38bfae36526 moved the .txt files pg_upgrade generates to a separate
> subdir, but there are a few left which are written to cwd. The thread
> resulting in that patch doesn't discuss these files specifically so it seems
> they are just an oversight. Unless I'm missing something.
> Should something the attached be applied to ensure all generated files are
> placed in the subdirectory?
It certainly looks inconsistent ATM. I wondered if maybe the plan was to
put routine output into the log directory but problem-reporting files
into cwd --- but that isn't what's happening now.
As long as we report the path to where the file is, I don't see a reason
not to put problem-reporting files in the subdir too.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade generated files in subdir follow-up
In-Reply-To: <4061927.1661954367@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox