From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
Date: Mon, 18 Aug 2025 11:38:02 -0400
Message-ID: <414029.1755531482@sss.pgh.pa.us> (raw)
In-Reply-To: <lmhmhxxwchxqogb3kybp5w2myvtsamtjkz6y2buowktd3sc3hg@pw5ebya2gifc>
References: <aKJsWedftW7UX1WM@paquier.xyz>
<lmhmhxxwchxqogb3kybp5w2myvtsamtjkz6y2buowktd3sc3hg@pw5ebya2gifc>
Andres Freund <andres@anarazel.de> writes:
> On 2025-08-18 08:57:13 +0900, Michael Paquier wrote:
>> The following command fails, because btree_gist is not installed in
>> the context of the isolation tests:
>> make -C src/test/isolation/
>> ...
>> and it does not strike me as a good idea to begin doing that in the main
>> isolation test suite, so perhaps the best thing to do here is just move this
>> test to contrib/btree_gist/?
> No, it makes absolutely no sense to test e.g. hash killtuples support in
> btree_gist.
I think the complaint is that nothing has been done to ensure that
these modules have been installed. You created a new dependency that
developers have to work around, rather than teaching the build system
to handle it. As a comparison point, all of the tests in
src/test/recovery, src/test/authentication, etc take care to install
required modules when you say "make check" in those directories.
You broke that for src/test/isolation, and you should fix it.
It shouldn't be much harder than setting EXTRA_INSTALL in the
Makefile case; I dunno about meson.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
In-Reply-To: <414029.1755531482@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox