From: David Steele <david@pgmasters.net>
To: Vaishnavi Prabakaran <vaishnaviprabakaran@gmail.com>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Prabakaran, Vaishnavi <VaishnaviP@fast.au.fujitsu.com>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
Cc: Dmitry Igrishin <dmitigr@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Manuel Kniep <m.kniep@web.de>
Cc: fujita.etsuro@lab.ntt.co.jp <fujita.etsuro@lab.ntt.co.jp>
Cc: Iwata, Aya <iwata.aya@jp.fujitsu.com>
Subject: Re: PATCH: Batch/pipelining support for libpq
Date: Fri, 31 Mar 2017 11:03:26 -0400
Message-ID: <41685247-0a06-1fbb-d731-1b2b6bd8df8e@pgmasters.net> (raw)
In-Reply-To: <3200d6d3-a82a-4778-b021-475b3adbe4dc@manitou-mail.org>
References: <3200d6d3-a82a-4778-b021-475b3adbe4dc@manitou-mail.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hi,
On 3/30/17 2:12 PM, Daniel Verite wrote:
> Vaishnavi Prabakaran wrote:
>
>> Hmm, With batch mode, after sending COPY command to server(and server
>> started processing the query and goes into COPY state) , client does not
>> immediately read the result , but it keeps sending other queries to the
>> server. By this time, server already encountered the error
>> scenario(Receiving different message during COPY state) and sent error
>> messages
>
> IOW, the test intentionally violates the protocol and then all goes wonky
> because of that.
> That's why I was wondering upthread what's it's supposed to test.
> I mean, regression tests are meant to warn against a desirable behavior
> being unknowingly changed by new code into an undesirable behavior.
> Here we have the undesirable behavior to start with.
> What kind of regression could we fear from that?
The CF has been extended until April 7 but time is still growing short.
Please respond with a new patch by 2017-04-04 00:00 AoE (UTC-12) or this
submission will be marked "Returned with Feedback".
Thanks,
--
-David
david@pgmasters.net
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, vaishnaviprabakaran@gmail.com, craig@2ndquadrant.com, daniel@manitou-mail.org, michael.paquier@gmail.com, VaishnaviP@fast.au.fujitsu.com, kommi.haribabu@gmail.com, tsunakawa.takay@jp.fujitsu.com, dmitigr@gmail.com, andres@anarazel.de, m.kniep@web.de, fujita.etsuro@lab.ntt.co.jp, iwata.aya@jp.fujitsu.com
Subject: Re: PATCH: Batch/pipelining support for libpq
In-Reply-To: <41685247-0a06-1fbb-d731-1b2b6bd8df8e@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox