From: Cédric Villemain <cedric@2ndquadrant.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org, Josh Berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Mon, 30 Sep 2013 08:50:38 +0200
Message-ID: <41858909.8rl4vTGUkV@obelix> (raw)
In-Reply-To: <5248F9A1.1000002@dunslane.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
<5248B32E.1090001@dunslane.net>
<5248F9A1.1000002@dunslane.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Le lundi 30 septembre 2013 00:10:09 Andrew Dunstan a écrit :
> On 09/29/2013 07:09 PM, Andrew Dunstan wrote:
> > On 09/03/2013 04:04 AM, Cédric Villemain wrote:
> >>> Simple one, attached.
> >>> I didn't document USE_VPATH, not sure how to explain that clearly.
> >>
> >> Just a remember that the doc is written and is waiting to be
> >> commited.
> >>
> >> There is also an issue spoted by Christoph with the installdirs
> >> prerequisite,
> >> the attached patch fix that.
> >
> > I applied this one line version of the patch, which seemed more
> > elegant than the later one supplied.
> >
> > I backpatched that and the rest of the VPATH changes for extensiuons
> > to 9.1 where we first provided for extensions, so people can have a
> > reasonably uniform build system for their extensions.
>
> I have reverted this in the 9.2 and 9.1 branches until I can work out
> why it's breaking the buildfarm. 9.3 seems to be fine.
Yes, please take the longer but better patch following the small one.
There are eveidences that it fixes compilation to always build
installdirs first.
Previously installdirs may be build after copying files, so it fails.
Chritstoph authored this good patch.
I'm sorry not to have been clear on that.
--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation
Attachments:
signature.asc (application/pgp-signature, 489B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: cedric@2ndquadrant.com, andrew@dunslane.net, josh@agliodbs.com, robertmhaas@gmail.com, peter_e@gmx.net, craig@2ndquadrant.com
Subject: Re: Bugfix and new feature for PGXS
In-Reply-To: <41858909.8rl4vTGUkV@obelix>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox