From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Declaration fixes
Date: Thu, 12 May 2022 13:18:05 -0400
Message-ID: <418904.1652375885@sss.pgh.pa.us> (raw)
In-Reply-To: <20220512164513.vaheofqp2q24l65r@alap3.anarazel.de>
References: <20220512164513.vaheofqp2q24l65r@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> I was experimenting with specifying symbol visiblity for functions explicitly,
> i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of
> src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I compared
> the set of exported symbols before / after, leading me to find a few
> pre-existing "issues".
> I think the attached patches are all a good idea and trivial enought that I
> think we should apply them now.
+1 to all of that. Would the changes you're working on result in getting
warnings for these sorts of oversights on mainstream compilers?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
Subject: Re: Declaration fixes
In-Reply-To: <418904.1652375885@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox