From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Our naming of wait events is a disaster.
Date: Tue, 12 May 2020 16:00:46 -0400
Message-ID: <4221.1589313646@sss.pgh.pa.us> (raw)
In-Reply-To: <CANP8+jKpSfOnd7CGYwnS4m1r8jsJYy9V5uJDk+Z1h6mHTe6wQw@mail.gmail.com>
References: <21247.1589296570@sss.pgh.pa.us>
<270FBE56-4F83-4FDE-BFFC-18EFF54DE30A@yandex-team.ru>
<31271.1589307094@sss.pgh.pa.us>
<CANP8+jKpSfOnd7CGYwnS4m1r8jsJYy9V5uJDk+Z1h6mHTe6wQw@mail.gmail.com>
Simon Riggs <simon@2ndquadrant.com> writes:
> On Tue, 12 May 2020 at 19:11, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Anyway, I was just throwing this idea out to see if there would be
>> howls of "you can't rename anything" anguish. Since there haven't
>> been so far, I'll spend a bit more time and try to create a concrete
>> list of possible changes.
> If we add in extensions and lwlocks, will they show up as well?
Yeah, I was just looking into that. Part of the reason for the
inconsistency is that we've exposed names that are passed to,
eg, SimpleLruInit that previously were strictly internal debugging
identifiers, so that approximately zero thought was put into them.
We're going to have to document SimpleLruInit and similar functions
along the lines of "The name you give here will be user-visible as
a wait event. Choose it with an eye to consistency with existing
wait event names, and add it to the user-facing documentation."
But that requirement isn't something I just invented, it was
effectively created by whoever implemented things this way.
Said user-facing documentation largely fails to explain that the
set of wait events can be enlarged by extensions; that needs to
be fixed, too.
There isn't a lot we can do to force extensions to pick consistent
names, but on the other hand we won't be documenting such names
anyway, so for my immediate purposes it doesn't matter ;-)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, simon@2ndquadrant.com, x4mmm@yandex-team.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: Our naming of wait events is a disaster.
In-Reply-To: <4221.1589313646@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox