From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Our naming of wait events is a disaster.
Date: Sat, 16 May 2020 10:46:57 -0400
Message-ID: <4505.1589640417@sss.pgh.pa.us> (raw)
In-Reply-To: <4929.1589337345@sss.pgh.pa.us>
References: <21247.1589296570@sss.pgh.pa.us>
<CA+hUKGJZeRVpmaAK73=q9237jQx-Y1gpWdrs9RNu0pXA+cV2wg@mail.gmail.com>
<4929.1589337345@sss.pgh.pa.us>
I wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
>> On Wed, May 13, 2020 at 3:16 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Hash/Batch/Allocating
>>> Hash/Batch/Electing
>>> Hash/Batch/Loading
>>> Hash/GrowBatches/Allocating
>> Perhaps we should also drop the 'ing' from the verbs, to be more like
>> ...Read etc.
> Yeah, that aspect was bothering me too. Comparing these to other
> wait event names, you could make a case for either "Allocate" or
> "Allocation"; but there are no other names with -ing.
After contemplating these for a bit, my proposal is to drop the
slashes and convert "verbing" to "verb", giving
HashBatchAllocate
HashBatchElect
HashBatchLoad
HashBuildAllocate
HashBuildElect
HashBuildHashInner
HashBuildHashOuter
HashGrowBatchesAllocate
HashGrowBatchesDecide
HashGrowBatchesElect
HashGrowBatchesFinish
HashGrowBatchesRepartition
HashGrowBucketsAllocate
HashGrowBucketsElect
HashGrowBucketsReinsert
In addition to that, I think the ClogGroupUpdate event needs to be renamed
to XactGroupUpdate, since we changed "clog" to "xact" in the exposed SLRU
and LWLock names.
(There are some other names that I wouldn't have picked in a green field,
but it's probably not worth the churn to change them.)
Also, as previously noted, ProcSignalBarrier should be in the IPC event
class not IO.
Barring objections, I'll make these things happen before beta1.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Our naming of wait events is a disaster.
In-Reply-To: <4505.1589640417@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox