From: Ronan Dunklau <ronan.dunklau@aiven.io>
To: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Provide a pg_truncate_freespacemap function
Date: Thu, 07 Mar 2024 08:59:02 +0100
Message-ID: <4331161.ejJDZkT8p0@aivenlaptop> (raw)
In-Reply-To: <ZejD7P+i2ZPDw8O/@tamriel.snowman.net>
References: <5446938.Sb9uPGUboI@aivenlaptop>
<ZejD7P+i2ZPDw8O/@tamriel.snowman.net>
Le mercredi 6 mars 2024, 20:28:44 CET Stephen Frost a écrit :
> I agree that this would generally be a useful thing to have.
Thanks !
>
> > Does that seem correct ?
>
> Definitely needs to have a 'REVOKE ALL ON FUNCTION' at the end of the
> upgrade script, similar to what you'll find at the bottom of
> pg_visibility--1.1.sql in the tree today, otherwise anyone could run it.
>
> Beyond that, I'd suggest a function-level comment above the definition
> of the function itself (which is where we tend to put those- not at the
> point where we declare the function).
Thank you for the review. Here is an updated patch for both of those.
Best regards,
--
Ronan
Attachments:
0002-Provide-a-pg_truncate_freespacemap-function.patch (text/x-patch, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ronan.dunklau@aiven.io, sfrost@snowman.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Provide a pg_truncate_freespacemap function
In-Reply-To: <4331161.ejJDZkT8p0@aivenlaptop>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox