From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove utils/acl.h from catalog/objectaddress.h
Date: Tue, 10 Mar 2020 10:35:51 +0100
Message-ID: <44263f2b-da18-1d05-d628-d76a330c79f3@2ndquadrant.com> (raw)
In-Reply-To: <20200309160707.GA3597@alvherre.pgsql>
References: <20200309160707.GA3597@alvherre.pgsql>
On 2020-03-09 17:07, Alvaro Herrera wrote:
> On 2020-Mar-07, Peter Eisentraut wrote:
>
>> I noticed that catalog/objectaddress.h includes utils/acl.h for no apparent
>> reason. It turns out this used to be needed but not anymore. So removed it
>> and cleaned up the fallout. Patch attached.
>
> parser/parse_nodes.h already includes nodes/parsenodes.h, so the seeming
> redundancy in places such as
>
>> diff --git a/src/include/commands/vacuum.h b/src/include/commands/vacuum.h
>> index c27d255d8d..be63e043c6 100644
>> --- a/src/include/commands/vacuum.h
>> +++ b/src/include/commands/vacuum.h
>> @@ -19,6 +19,7 @@
>> #include "catalog/pg_statistic.h"
>> #include "catalog/pg_type.h"
>> #include "nodes/parsenodes.h"
>> +#include "parser/parse_node.h"
>
> (and others) is not just apparent; it's also redundant in practice. And
> it's not like parse_node.h is ever going to be able not to depend on
> parsenodes.h, so I would vote to remove nodes/parsenodes.h from the
> headers where you're adding parser/parse_node.h.
OK, committed with your and Tom's changes.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com
Subject: Re: Remove utils/acl.h from catalog/objectaddress.h
In-Reply-To: <44263f2b-da18-1d05-d628-d76a330c79f3@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox