From: Adriaan van Os <postgres@microbizz.nl>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: [HACKERS] [BUGS] BUG #2907: pg_get_serial_sequence quoting
Date: Tue, 30 Jan 2007 16:10:07 +0100
Message-ID: <45BF5FCF.1080708@microbizz.nl> (raw)
In-Reply-To: <200701300234.l0U2Yr423647@momjian.us>
References: <200701300234.l0U2Yr423647@momjian.us>
Bruce Momjian wrote:
> Adriaan van Os wrote:
>> Tom Lane wrote:
>>> Bruce Momjian <bruce@momjian.us> writes:
>>>>> I presume the reason for that is that the first paramater can be
>>>>> qualified:
>>>>> select pg_get_serial_sequence('"public"."FOO"', 'Ff1');
>>>> Would someone explain why qualification makes us lowercase the first
>>>> parameter by default? I don't understand it well enough to document it.
>>> The point is that we have to parse the first parameter, whereas the
>>> second one can be taken literally.
>> It still looks inconsistent and ugly. I think the design mistake of pg_get_serial_sequence is that
>> it takes two parameters rather than one (a fully qualified doublequoted columnname path) or three
>> (optionally empty schema, tablename, columnname, all three literal).
>
> I did my best to document the behavior of pg_get_serial_sequence().
> There actually is a technical reason why we can't auto-quote the first
> parameter. Patch applied to HEAD and 8.2.X.
Thanks for the doc change.
Adriaan van Os
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: postgres@microbizz.nl, bruce@momjian.us, pgsql-patches@postgresql.org
Subject: Re: [HACKERS] [BUGS] BUG #2907: pg_get_serial_sequence quoting
In-Reply-To: <45BF5FCF.1080708@microbizz.nl>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox