From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: Jesse Zhang <sbjesse@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Thu, 13 Aug 2020 12:50:16 -0400
Message-ID: <469403.1597337416@sss.pgh.pa.us> (raw)
In-Reply-To: <20200813163043.GZ29590@tamriel.snowman.net>
References: <20200812223409.6di3y2qsnvynao7a@alap3.anarazel.de>
<CAGf+fX71Oa2vzg0xdj+vgrjmdVrm=kRLc7H3SEGtCHkGhoWDCg@mail.gmail.com>
<328084.1597276021@sss.pgh.pa.us>
<20200813035308.GA1137170@rfd.leadboat.com>
<397020.1597291716@sss.pgh.pa.us>
<CABUevEwg3LmBk-+ZiAYZW71dsB=boS-8sdYBux7M6qZp46avtA@mail.gmail.com>
<20200813163043.GZ29590@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
> So, in our world, wouldn't this translate to 'make cfbot complain'?
> I'm definitely a fan of the idea of having cfbot flag these and then we
> maybe get to a point where it's not the committers dealing with fixing
> patches that weren't pgindent'd properly, it's the actual patch
> submitters being nagged about it...
Meh. Asking all submitters to install pgindent is a bit of a burden.
Moreover, sometimes it's better to provide a patch that deliberately
hasn't reindented existing code, for ease of review (say, when you're
adding if() { ... } around some big hunk of code). I think getting
committers to do this as part of commit is a better workflow.
(Admittedly, since I've been doing that for a long time, I don't
find it to be a burden. I suppose some committers do.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, magnus@hagander.net, noah@leadboat.com, sbjesse@gmail.com, andres@anarazel.de
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <469403.1597337416@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox