From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kris Jurka <books@ejurka.com>
Cc: Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Gorm.Andersen@Sun.COM
Subject: Re: compiler warnings on the buildfarm
Date: Fri, 13 Jul 2007 14:25:16 +0200
Message-ID: <46976F2C.4090303@sun.com> (raw)
In-Reply-To: <27687.1184290111@sss.pgh.pa.us>
References: <46962BBD.5000108@kaltenbrunner.cc>
<17428.1184249229@sss.pgh.pa.us>
<469653BA.2040004@kaltenbrunner.cc>
<20917.1184257896@sss.pgh.pa.us>
<46969A2E.2020608@kaltenbrunner.cc>
<16415.1184285944@sss.pgh.pa.us>
<Pine.BSO.4.64.0707122025210.19651@leary.csoft.net>
<27687.1184290111@sss.pgh.pa.us>
Tom Lane wrote:
> Kris Jurka <books@ejurka.com> writes:
>> So pam_message ** isn't const.
>
> Ah, thanks. I see luna_moth is giving the same warning, so it's still
> not const in Solaris 11 either.
>
> Is it worth working around this? It's strictly cosmetic AFAICS.
>
> The main issue in my mind would be how to determine whether to use
> const or not. If all Solaris releases are like this, and can be
> expected to stay that way,
I think yes. It is defined as X/Open standard says.
> I'd be inclined to just put a "#define
> PAM_CONV_PROC_NOT_CONST" in include/port/solaris.h and drive the
> function declaration off that. If there's a version dependency
> involved then it gets a lot more complicated, and might not be worth
> the trouble.
Following patch works for me, but I did not test it on other platform.
retrieving revision 1.153
diff -r1.153 auth.c
61c61
< &pam_passwd_conv_proc,
---
> (int (*)())pam_passwd_conv_proc,
Zdenek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: Zdenek.Kotala@Sun.COM, tgl@sss.pgh.pa.us, books@ejurka.com, stefan@kaltenbrunner.cc, Gorm.Andersen@Sun.COM
Subject: Re: compiler warnings on the buildfarm
In-Reply-To: <46976F2C.4090303@sun.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox