From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
Date: Tue, 19 Jan 2021 10:27:21 -0500
Message-ID: <479372.1611070041@sss.pgh.pa.us> (raw)
In-Reply-To: <20210119111625.20435-1-james.hilliard1@gmail.com>
References: <20210119111625.20435-1-james.hilliard1@gmail.com>
James Hilliard <james.hilliard1@gmail.com> writes:
> Fixes:
> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -I../../../../src/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -c -o fd.o fd.c
> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
We already dealt with that by not selecting an SDK newer than the
underlying OS (see 4823621db). I do not believe that your proposal
is more reliable than that approach, and it's surely uglier. Are
we really going to abandon Autoconf's built-in checking method every
time Apple adds an API they should have had ten years ago? If so,
you forgot preadv ...
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, james.hilliard1@gmail.com, s.shinderuk@postgrespro.ru, thomas.munro@gmail.com
Subject: Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
In-Reply-To: <479372.1611070041@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox