pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Noah Misch <noah@leadboat.com>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Denis Laxalde <denis.laxalde@dalibo.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Greg Stark <stark@mit.edu>
Cc: Gregory Stark (as CFM) <stark.cfm@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Date: Thu, 21 Nov 2024 19:37:34 -0500
Message-ID: <480238.1732235854@sss.pgh.pa.us> (raw)
In-Reply-To: <CAGECzQQFvsuBcT1Bu3eDWDWuxt=GT0MsGJJKK_5og51Rk-4q7Q@mail.gmail.com>
References: <202407221126.vyw5q3h4nyoh@alvherre.pgsql>
	<5ea25e4d-1ee2-b9bf-7806-119ffa658826@gmail.com>
	<578934.1725045685@sss.pgh.pa.us>
	<CAGECzQQZi_po92DSgo75vmM-KxG2zMGzo-tt+Z+85w3BgL89ug@mail.gmail.com>
	<584811.1725048717@sss.pgh.pa.us>
	<591893.1725051309@sss.pgh.pa.us>
	<37c3bd11-7321-fe58-99ca-bc15a67c08cc@gmail.com>
	<c68225b4-fce9-3425-1534-a21a815d5846@gmail.com>
	<colnv3lzzmc53iu5qoawynr6qq7etn47lmggqr65ddtpjliq5d@glkveb4m6nop>
	<2947163.1731810791@sss.pgh.pa.us>
	<8f280cbd-8450-87ea-f0f7-ab4932af5750@gmail.com>
	<321476.1732152654@sss.pgh.pa.us>
	<CAGECzQQFvsuBcT1Bu3eDWDWuxt=GT0MsGJJKK_5og51Rk-4q7Q@mail.gmail.com>

Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> On Thu, 21 Nov 2024 at 02:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This seems to fix the problem here.  Thoughts?

> Overall, a good approach to fix issue number 1. I think it would be
> best if this was integrated into libpqsrv_cancel instead though. That
> way the dblink would benefit from it too.

How would we do that?  libpqsrv_cancel is not chartered to wait around
for the results of the cancel, and I'm not even sure that it could
know what to check for.

(I did get the impression that all this code was not very well
factored, but I'm not volunteering to rewrite it wholesale.)

> nit: Maybe call it RETRY_CANCEL_TIME.

Sure.

			regards, tom lane





view thread (146+ messages)  latest in thread

Message-ID: <480238.1732235854@sss.pgh.pa.us>
Permalink:  ../480238.1732235854@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/480238.1732235854@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, postgres@jeltef.nl, exclusion@gmail.com, andres@anarazel.de, alvherre@alvh.no-ip.org, noah@leadboat.com, jacob.champion@enterprisedb.com, denis.laxalde@dalibo.com, vignesh21@gmail.com, thomas.munro@gmail.com, stark@mit.edu, stark.cfm@gmail.com, daniel@yesql.se, peter@eisentraut.org, pryzby@telsasoft.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org, etsuro.fujita@gmail.com
  Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
  In-Reply-To: <480238.1732235854@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox