From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
Date: Tue, 19 Jan 2021 10:57:25 -0500
Message-ID: <480660.1611071845@sss.pgh.pa.us> (raw)
In-Reply-To: <CADvTj4riiHN9Zhhk5qOVndevQMOxuduFbFVVJnCiQ4R7k5_eng@mail.gmail.com>
References: <20210119111625.20435-1-james.hilliard1@gmail.com>
<479372.1611070041@sss.pgh.pa.us>
<CADvTj4riiHN9Zhhk5qOVndevQMOxuduFbFVVJnCiQ4R7k5_eng@mail.gmail.com>
James Hilliard <james.hilliard1@gmail.com> writes:
> On Tue, Jan 19, 2021 at 8:27 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We already dealt with that by not selecting an SDK newer than the
>> underlying OS (see 4823621db).
> Tried that, doesn't work, not even sure how it could possibly fix this
> issue at all,
It worked for me and for Sergey, so we need to figure out what's different
about your setup. What do you get from "xcrun --show-sdk-path" and
"xcrun --sdk macosx --show-sdk-path"? What have you got under
/Library/Developer/CommandLineTools/SDKs ?
> this can not be fixed properly by selecting a specific SDK version
> alone, it's the symbols valid for a specific target deployment version
> that matters here.
I don't think I believe that argument. As a counterexample, supposing
that somebody were intentionally cross-compiling on an older OSX platform
but using a newer SDK, shouldn't they get an executable suited to the
SDK's target version?
(I realize that Apple thinks we ought to handle that through run-time
not compile-time adaptation, but I have no interest in going there.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, james.hilliard1@gmail.com, s.shinderuk@postgrespro.ru, thomas.munro@gmail.com
Subject: Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
In-Reply-To: <480660.1611071845@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox