From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: bloated heapam.h
Date: Sat, 10 May 2008 13:52:28 +0200
Message-ID: <48258C7C.9030103@sun.com> (raw)
In-Reply-To: <20080509185610.GJ5748@alvh.no-ip.org>
References: <20080509185610.GJ5748@alvh.no-ip.org>
Alvaro Herrera napsal(a):
> Others are more conflictive. For example syncscan.c is keeping the
> prototypes for its own functions on heapam.h. Also pruneheap.c and
> rewriteheap.c. As a result, not only themselves need to include
> heapam.h (without any other need for it), but they force some other
> files into including heapam.h to get their prototypes. I think this is
> a mistake; I propose splitting those prototypes to their own files, and
> #including those as appropriate.
>
> Objections?
I have similar thing in my TODO list. See my patch from March commit fest and
discussion. I need solve two main issues - remove postgres.h from binaries and
keep history of structures (for pg_upgrade project).
My idea is split structures and functions in separate header files.
Zdenek
http://archives.postgresql.org/pgsql-patches/2007-10/msg00197.phphttp://archives.postgresql.org/pgsql-patches/2008-04/msg00149.php
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: Zdenek.Kotala@Sun.COM, alvherre@commandprompt.com
Subject: Re: bloated heapam.h
In-Reply-To: <48258C7C.9030103@sun.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox