pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Updating FSM on recovery
Date: Tue, 28 Oct 2008 19:10:17 +0200
Message-ID: <49074779.2080309@enterprisedb.com> (raw)
In-Reply-To: <24334.1225205478@sss.pgh.pa.us>
References: <49072021.7010801@enterprisedb.com>
	<24334.1225205478@sss.pgh.pa.us>

Tom Lane wrote:
> As far as the ugliness in XLogRecordPageWithFreeSpace goes: couldn't you
> just call XLogReadBufferWithFork with init = true, and then initialize
> the page if PageIsNew?

With init=true, we don't even try to read the page from the disk (since 
8.3), so all FSM pages accessed during recovery would be zeroed out. I 
don't think that's what you intended.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com



view thread (16+ messages)  latest in thread

Message-ID: <49074779.2080309@enterprisedb.com>
Permalink:  ../49074779.2080309@enterprisedb.com/
Also on:    postgresql.org/message-id/49074779.2080309@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: heikki.linnakangas@enterprisedb.com, tgl@sss.pgh.pa.us
  Subject: Re: Updating FSM on recovery
  In-Reply-To: <49074779.2080309@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox