From: Joe Conway <mail@joeconway.com>
To: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Joshua Brindle <joshua.brindle@crunchydata.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: use has_privs_of_role() for pg_hba.conf
Date: Thu, 6 Oct 2022 07:33:46 -0400
Message-ID: <491dba16-55df-d5fd-1ae7-01b5140987f0@joeconway.com> (raw)
In-Reply-To: <Yz6NRrfd7n2AXoHh@paquier.xyz>
References: <20220401220648.GA615994@nathanxps13>
<CAGB+Vh5epaDEu7aRokcuc_a7yG0B49u9ebpdViJHpyFN-exJtQ@mail.gmail.com>
<20220404142551.GB663209@nathanxps13>
<Yz6NRrfd7n2AXoHh@paquier.xyz>
On 10/6/22 04:09, Michael Paquier wrote:
> On Mon, Apr 04, 2022 at 07:25:51AM -0700, Nathan Bossart wrote:
>> On Mon, Apr 04, 2022 at 09:36:13AM -0400, Joshua Brindle wrote:
>>> Good catch, I think this is a logical followup to the previous
>>> has_privs_of_role patch.
>>>
>>> Reviewed and +1
>>
>> Thanks! I created a commitfest entry for this:
>
> This patch looks simple, but it is a very sensitive area so I think
> that we should be really careful. pg_hba.conf does not have a lot of
> test coverage, so I'd really prefer if we add something to see the
> difference of behavior and check the behavior that we are switching
> here.
Agreed
> Joe, you are registered as a reviewer and committer of this patch, by
> the way. Are you planning to look at it?
I am meaning to get to it, but as you say wanted to spend some time to
understand the nuances and life keeps getting in the way. I will try to
prioritize it over the next week.
Joe
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: mail@joeconway.com, michael@paquier.xyz, nathandbossart@gmail.com, joshua.brindle@crunchydata.com
Subject: Re: use has_privs_of_role() for pg_hba.conf
In-Reply-To: <491dba16-55df-d5fd-1ae7-01b5140987f0@joeconway.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox