pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Magnus Hagander <magnus@hagander.net>
To: PG Hackers <pgsql-hackers@postgresql.org>
Subject: Error arguments in pl_exec.c
Date: Thu, 20 Nov 2008 15:58:42 +0100
Message-ID: <49257B22.6070005@hagander.net> (raw)

I get the following warnings in HEAD

pl_exec.c: In function ‘exec_stmt_raise’:
pl_exec.c:2538: warning: format not a string literal and no format arguments
pl_exec.c:2538: warning: format not a string literal and no format arguments


Attached patch seems right to me - objections?

//Magnus

Attachments:

  [text/x-diff] plexec.diff (893B, ../49257B22.6070005@hagander.net/2-plexec.diff)
  download | inline diff:
Index: pl_exec.c
===================================================================
RCS file: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v
retrieving revision 1.224
diff -c -r1.224 pl_exec.c
*** pl_exec.c	5 Nov 2008 00:07:54 -0000	1.224
--- pl_exec.c	20 Nov 2008 14:58:11 -0000
***************
*** 2538,2545 ****
  	ereport(stmt->elog_level,
  			(err_code ? errcode(err_code) : 0,
  			 errmsg_internal("%s", err_message),
! 			 (err_detail != NULL) ? errdetail(err_detail) : 0,
! 			 (err_hint != NULL) ? errhint(err_hint) : 0));
  
  	estate->err_text = NULL;	/* un-suppress... */
  
--- 2538,2545 ----
  	ereport(stmt->elog_level,
  			(err_code ? errcode(err_code) : 0,
  			 errmsg_internal("%s", err_message),
! 			 (err_detail != NULL) ? errdetail("%s", err_detail) : 0,
! 			 (err_hint != NULL) ? errhint("%s", err_hint) : 0));
  
  	estate->err_text = NULL;	/* un-suppress... */
  

view thread (4+ messages)  latest in thread

Message-ID: <49257B22.6070005@hagander.net>
Permalink:  ../49257B22.6070005@hagander.net/
Also on:    postgresql.org/message-id/49257B22.6070005@hagander.net

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: magnus@hagander.net
  Subject: Re: Error arguments in pl_exec.c
  In-Reply-To: <49257B22.6070005@hagander.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox