From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: foreign_data test fails with non-C locale
Date: Fri, 09 Jan 2009 10:21:46 -0500
Message-ID: <49676B8A.8020707@dunslane.net> (raw)
In-Reply-To: <49675E4E.1080805@gmx.net>
References: <49675B3F.20002@enterprisedb.com>
<49675C87.8070303@dunslane.net>
<49675E4E.1080805@gmx.net>
Peter Eisentraut wrote:
> Andrew Dunstan wrote:
>> Regression tests have always failed on non-C locales AFAIK. The
>> buildfarm goes out of its way to avoid that.
>
> The regression tests should work just fine in non-C locales. If the
> buildfarm goes out of its way to avoid non-C locales, then it loses
> some significant code coverage, considering that there are several
> variant code paths for locales, and considering the amount of users
> that use them.
It was discussed here at the time, IIRC, and we put in the check
precisely because other locales broke the buildfarm. Originally
buildfarm just inherited the locale from its environment.
If it is no longer true that other locales break the tests, then I'm
happy to examine alternatives.
cheers
andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, peter_e@gmx.net, heikki.linnakangas@enterprisedb.com
Subject: Re: foreign_data test fails with non-C locale
In-Reply-To: <49676B8A.8020707@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox