pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Finnerty, Jim <jfinnert@amazon.com>
Subject: Re: Making Vars outer-join aware
Date: Mon, 30 Jan 2023 11:45:27 -0500
Message-ID: <497112.1675097127@sss.pgh.pa.us> (raw)
In-Reply-To: <CAMbWs4-H7jBUpPfjDzswkRdU+43nxtmezyfAJoC9=WDyD6GwkQ@mail.gmail.com>
References: <830269.1656693747@sss.pgh.pa.us>
	<CAMbWs49KZO2VvMqo+1MQfaX4cun7vhF=5RgVdpA0gjJcj77HFQ@mail.gmail.com>
	<1903934.1657031040@sss.pgh.pa.us>
	<553080.1657481916@sss.pgh.pa.us>
	<CAMbWs4-0cdVpgY0c2uULBCX2vPjQt3Fx3=XFZh-Mn=UWmxhG-A@mail.gmail.com>
	<1515100.1657633061@sss.pgh.pa.us>
	<CAMbWs4_va6UWcaiPSZpeRPFzpA=UKU+4zKkxqdfrcKoKA5nKWA@mail.gmail.com>
	<2217146.1657721363@sss.pgh.pa.us>
	<2055912.1659383493@sss.pgh.pa.us>
	<CAMbWs480igxj6hTbvD0WEnzT4XJ8hJXg71EVJO_BcQqN90MQuA@mail.gmail.com>
	<1188905.1660666103@sss.pgh.pa.us>
	<1405792.1660677844@sss.pgh.pa.us>
	<1538543.1660683428@sss.pgh.pa.us>
	<CAMbWs498oYx4pjzOsjxu0wG0D73e2+OFAqkbPotcSJDKzm-s4Q@mail.gmail.com>
	<2741731.1660848346@sss.pgh.pa.us>
	<CAMbWs4-mvPPCJ1W6iK6dD5HiNwoJdi6mZp=-7mE8N9Sh+cd0tQ@mail.gmail.com>
	<CAMbWs4_WNcvQGiFMLJanj3h6WMzFi6P-=bifmnuXUcg4PSXQgA@mail.gmail.com>
	<1035990.1667261942@sss.pgh.pa.us>
	<2901865.1667685211@sss.pgh.pa.us>
	<CAMbWs4_pH7w7voY0AejUM4RiKq-Xuf+sXmoF8PcQwzNrsagEXA@mail.gmail.com>
	<CAMbWs! 4_gXgGdkkOraUPEoZD_Q3xTW7FTxfomW+fxPN2Kr-YSXg@mail.gmail.com>
	<4019771.1672155080@sss.pgh.pa.us>
	<CAMbWs4_JDDdXvEBWtTao9ZTwOGdDCU7X-=bF7yi9G1u_-b0Dfw@mail.gmail.com>
	<323812.1672241806@sss.pgh.pa.us>
	<2043562.1674506286@sss.pgh.pa.us>
	<CAMbWs4-H7jBUpPfjDzswkRdU+43nxtmezyfAJoC9=WDyD6GwkQ@mail.gmail.com>

Richard Guo <guofenglinux@gmail.com> writes:
> Sorry for the delayed reply.  I don't have any more review comments at
> the moment, except a nitpicking one.

> In optimizer/README at line 729 there is a query as

>     SELECT * FROM a
>       LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = b.y)
>     WHERE a.x = 1;

> I think it should be

>     SELECT * FROM a
>       LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = ss.y)
>     WHERE a.x = 1;

Oh, good catch, thanks.

> I have no objection to get it committed.

I'll push forward then.  Thanks for reviewing!

			regards, tom lane





view thread (60+ messages)  latest in thread

Message-ID: <497112.1675097127@sss.pgh.pa.us>
Permalink:  ../497112.1675097127@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/497112.1675097127@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, guofenglinux@gmail.com, pgsql-hackers@lists.postgresql.org, jfinnert@amazon.com
  Subject: Re: Making Vars outer-join aware
  In-Reply-To: <497112.1675097127@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox