From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: Translation of the NextOID message in pg_controldata
Date: Mon, 14 Sep 2026 00:32:18 -0400
Message-ID: <49855.1789360338@sss.pgh.pa.us> (raw)
In-Reply-To: <20260914.124645.2220219320843846932.horikyota.ntt@gmail.com>
References: <20260914.124645.2220219320843846932.horikyota.ntt@gmail.com>
Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> Commit cb298616463 changed the following line:
> - printf(_("Latest checkpoint's NextOID: %u\n"),
> + printf(_("Latest checkpoint's NextOID: " OID8_FORMAT "\n"),
> It appears that xgettext does not recognize PostgreSQL's OID8_FORMAT
> macro and therefore extracts only the preceding string literal as the
> msgid. In contrast, PRIu64, which is used in the same file, is
> correctly extracted as %<PRIu64>. Therefore, shouldn't we use "%"
> PRIu64 instead of OID8_FORMAT here as well?
That would be fairly sad, because it means hard-wiring the fact that
Oid8 is the same as uint64 in a bunch of non-obvious places.
Admittedly, we've lived with formatting Oid as %u for a long time.
But can we fix this some other way?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, michael@paquier.xyz
Subject: Re: Translation of the NextOID message in pg_controldata
In-Reply-To: <49855.1789360338@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox