From: Maksim Milyutin <milyutinma@gmail.com>
To: Rafia Sabih <rafia.sabih@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Hint to set owner for tablespace directory
Date: Fri, 31 Aug 2018 13:41:35 +0300
Message-ID: <498a6ff8-7036-bec9-7d09-f3e24cb65b96@gmail.com> (raw)
In-Reply-To: <CAOGQiiMGNOO5mwqsvDHavsHMFRe1jGFFTFc+FGbY5Cz7WoD=Qw@mail.gmail.com>
References: <5ca60e1a-26f9-89fd-e912-021dd2b8afe2@gmail.com>
<20180824021853.GG30782@paquier.xyz>
<3deda6f3-3dfb-0246-905b-f76638b7658f@gmail.com>
<CAOGQiiOTGCAiJ0uJK_8svk9XZdYyV29hpkNZZ6jmFrA8xRR_ww@mail.gmail.com>
<e3c5ad30-4170-6899-7558-5044819dbdc1@gmail.com>
<CAOGQiiMGNOO5mwqsvDHavsHMFRe1jGFFTFc+FGbY5Cz7WoD=Qw@mail.gmail.com>
On 08/31/2018 01:12 PM, Rafia Sabih wrote:
>
>
> On Fri, Aug 31, 2018 at 3:30 PM, Maksim Milyutin <milyutinma@gmail.com
> <mailto:milyutinma@gmail.com>> wrote:
>
> On 08/31/2018 11:55 AM, Rafia Sabih wrote:
>
>>
>> Adding to that this patch needs a rebase. And, please don't
>> forget to run 'git diff --check', as it has some white-space issues.
>
> git apply /home/edb/Desktop/patches/others/owner_tbsp_hint.patch
> /home/edb/Desktop/patches/others/owner_tbsp_hint.patch:9: trailing
> whitespace.
> {
> /home/edb/Desktop/patches/others/owner_tbsp_hint.patch:10: trailing
> whitespace.
> bool wrong_owner = (errno == EPERM);
This is hex+ASCII display (from *hexdump -C owner_tbsp_hint.patch*
output) of code fragment above:
000001a0 0a 20 09 09 65 6c 73 65 0a 2b 09 09 7b 0a 2b 09 |.
..else.+..{.+.|
000001b0 09 09 62 6f 6f 6c 20 77 72 6f 6e 67 5f 6f 77 6e |..bool
wrong_own|
000001c0 65 72 20 3d 20 28 65 72 72 6e 6f 20 3d 3d 20 45 |er = (errno
== E|
000001d0 50 45 52 4d 29 3b 0a 2b 0a 20 09 09 09 65 72 65 |PERM);.+.
...ere|
Problem lines don't have trailing whitespaces, only line feed (0x0a) symbols
> This is what I got. Please correct me if I am missng anything. I am
> using centos 7, just an FYI.
My git version is 2.7.4.
--
Regards, Maksim Milyutin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: milyutinma@gmail.com, rafia.sabih@enterprisedb.com, michael@paquier.xyz
Subject: Re: Hint to set owner for tablespace directory
In-Reply-To: <498a6ff8-7036-bec9-7d09-f3e24cb65b96@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox