From: Joe Conway <mail@joeconway.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hackers (PostgreSQL) <pgsql-hackers@postgresql.org>
Subject: Re: [Fwd: Re: dblink patches for comment]
Date: Sat, 06 Jun 2009 10:42:24 -0700
Message-ID: <4A2AAA80.9060905@joeconway.com> (raw)
In-Reply-To: <10658.1244304503@sss.pgh.pa.us>
References: <4A29E789.1050405@joeconway.com>
<10658.1244304503@sss.pgh.pa.us>
Tom Lane wrote:
> The quoting logic is still completely the wrong thing :-(. For one
> thing, quote_literal will try to generate E'' syntax in some cases.
> But more to the point, quote_literal's quoting rules don't match
> what is needed. A look at libpq's conninfo_parse says that what it
> accepts is single-quoted strings in which backslash quotes the next
> character. It does not recognize doubled single quotes. I think
> you will need to whip up a special-purpose quoting subroutine.
OK, I see that. I assume I need to care for encoding issues? If so, do I
assume server encoding or client encoding?
>> + return pstrdup(buf->data);
>
> is a waste of time. The StringInfo's buffer is already palloc'd.
Thanks -- will fix.
Joe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: mail@joeconway.com, tgl@sss.pgh.pa.us
Subject: Re: [Fwd: Re: dblink patches for comment]
In-Reply-To: <4A2AAA80.9060905@joeconway.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox