pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Petr Jelinek <pjmodos@pjmodos.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: GRANT ON ALL IN schema
Date: Mon, 10 Aug 2009 01:14:27 +0200
Message-ID: <4A7F5853.5010506@pjmodos.net> (raw)
In-Reply-To: <4A7F56A0.5060705@pjmodos.net>
References: <4A37BF63.50008@pjmodos.net>
	<4A37E122.8070303@pjmodos.net>
	<4A38A956.8080600@pjmodos.net>
	<4A4DE104.8090605@pjmodos.net>
	<a301bfd90907170254re7dd52es9fedb007376d8055@mail.gmail.com>
	<4A6059B4.5010004@pjmodos.net>
	<4A607997.3030305@pjmodos.net>
	<21542.1249492707@sss.pgh.pa.us>
	<4A7F56A0.5060705@pjmodos.net>

Petr Jelinek wrote:
> I attached revised version of the patch. Changes, thoughts:
> - SCHEMA is mandatory now
> - removed VIEWS and GRANT ON VIEW since it looks like only me and 
> Stephen want it there
> - the patch is now made so that adding new filters in the future won't 
> mean tearing of half of the parser code and replacing it
> - I decided to go with GRANT ON ALL IN SCHEMA syntax, because I am 
> thinking there is no difference in adding extended syntax to the 
> standard command in GRANT and in SELECT, ALTER TABLE and other 
> commands we extended. And I don't see any way standard could add 
> exactly same syntax for doing something completely different (which is 
> the only way they could break this).
Argh, why does this always happen to me ? Immediately after sending the 
patch I realized there needs to be one more little change done (merging 
tables and views in the getNamespacesObjectsOids function).

-- 
Regards
Petr Jelinek (PJMODOS)

Attachments:

  [application/x-tar] grantonall-20090810v2.diff.gz (5.1K, ../4A7F5853.5010506@pjmodos.net/2-grantonall-20090810v2.diff.gz)
  download

view thread (83+ messages)  latest in thread

Message-ID: <4A7F5853.5010506@pjmodos.net>
Permalink:  ../4A7F5853.5010506@pjmodos.net/
Also on:    postgresql.org/message-id/4A7F5853.5010506@pjmodos.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pjmodos@pjmodos.net, tgl@sss.pgh.pa.us
  Subject: Re: GRANT ON ALL IN schema
  In-Reply-To: <4A7F5853.5010506@pjmodos.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox