From: Ron Mayer <rm_pg@cheapcomplexdevices.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David E. Wheeler <david@kineticode.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: updated hstore patch
Date: Sun, 20 Sep 2009 06:21:38 -0700
Message-ID: <4AB62C62.5030109@cheapcomplexdevices.com> (raw)
In-Reply-To: <8763bejb5l.fsf@news-spur.riddles.org.uk>
References: <87zl8v36qo.fsf@news-spur.riddles.org.uk>
<39EDBE64-BE43-4A3E-9514-D7EB2EAD6D35@kineticode.com>
<14572.1253412218@sss.pgh.pa.us>
<8763bejb5l.fsf@news-spur.riddles.org.uk>
Andrew Gierth wrote:
> I'd appreciate public feedback on:
> - whether conversions to/from a {key,val,key,val,...} array are needed
> (and if there's strong opinions in favour of making them casts; in the
> absence of strong support for that, I'll stick to functions)
Strikes me as an independent separate patch. It seems totally
orthogonal to the features in the patch as submitted, no?
> - what to do when installing the new version's .sql into an existing db;
> the send/recv support and some of the index support doesn't get installed
> if the hstore type and opclasses already exist. In the case of an upgrade
> (or a dump/restore from an earlier version) it would be nice to make all
> the functionality available; but there's no CREATE OR REPLACE for types
> or operator classes.
It seems similar in ways to the PostGIS upgrade issues when their
types and operators change:
http://postgis.refractions.net/docs/ch02.html#upgrading
It seems they've settled on a script which processes the dump file
to exclude the parts that would conflict?
If the perfect solution is too complex, I'd also kinda hope this isn't a
show-stopper for this patch, but rather a TODO for the future modules feature.
> If there are any more potential showstoppers I'd appreciate hearing about
> them now rather than later.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rm_pg@cheapcomplexdevices.com, andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, david@kineticode.com
Subject: Re: updated hstore patch
In-Reply-To: <4AB62C62.5030109@cheapcomplexdevices.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox