From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop
Date: Mon, 19 Apr 2010 17:44:07 +0300
Message-ID: <4BCC6C37.9090703@enterprisedb.com> (raw)
In-Reply-To: <1271687489.8305.18879.camel@ebony>
References: <20100418180608.16F067541D1@cvs.postgresql.org>
<4BCC07F1.6040405@enterprisedb.com>
<1271664332.8305.17430.camel@ebony>
<4BCC1644.70008@enterprisedb.com>
<1271667922.8305.17650.camel@ebony>
<v2y603c8f071004190455gf18633fbx1a666c17c998b1a1@mail.gmail.com>
<13439.1271687068@sss.pgh.pa.us>
<1271687489.8305.18879.camel@ebony>
Simon Riggs wrote:
> On Mon, 2010-04-19 at 10:24 -0400, Tom Lane wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> On Mon, Apr 19, 2010 at 5:05 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>>> It doesn't seem to be something we should place highly on the list of
>>>> events we need protection from, does it?
>>> Since when do we not protect against race-conditions just because
>>> they're low likelihood?
>> Murphy's law says that the probability of any race condition happening
>> in the field is orders of magnitude higher than you think. This has
>> been proven true many times ...
Right. And some future code changes elsewhere could make it more likely,
by the time we've forgotten all about this.
> Choices are
>
> 1. Check RecoveryInProgress() once outside of lock, plus wild rumour of
> Murphy
>
> 2. Check RecoveryInProgress() before and after holding lock
>
> 3. Check RecoveryInProgress() while holding lock
4. Check RecoveryInProgress() once outside of lock, and scan the
ProcArray anyway, just in case. That's what we did before this patch.
Document that takenDuringRecovery == true means that the snapshot was
most likely taken during recovery, but there is some race conditions
where takenDuringRecovery is true even though the snapshot was taken
just after recovery finished. AFAICS all of the other current uses of
takenDuringRecovery work fine with that.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, simon@2ndQuadrant.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: Re: [COMMITTERS] pgsql: Tune GetSnapshotData() during Hot Standby by avoiding loop
In-Reply-To: <4BCC6C37.9090703@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox