From: Greg Smith <greg@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: bricklen <bricklen@gmail.com>
Cc: pgsql-general@postgresql.org
Subject: Re: Archiver not picking up changes to archive_command
Date: Mon, 10 May 2010 21:12:00 -0400
Message-ID: <4BE8AEE0.7080701@2ndquadrant.com> (raw)
In-Reply-To: <21571.1273539053@sss.pgh.pa.us>
References: <AANLkTinmg9-gtu9NUxebe-NKfk5dkhNY2-sa1H0-WxCr@mail.gmail.com>
<21571.1273539053@sss.pgh.pa.us>
Tom Lane wrote:
> A look at the code shows that the archiver only notices SIGHUP once
> per outer loop, so the change would only take effect once you catch up,
> which is not going to help much in this case. Possibly we should change
> it to check for SIGHUP after each archive_command execution.
>
I never considered this a really important issue to sort out because I
tell everybody it's unwise to put something complicated directly into
archive_command. Much better to call a script that gets passed %f/%p,
then let that script do all the work; don't even have to touch the
server config if you need to fix something then. The lack of error
checking that you get when just writing some shell commands directly in
the archive_command itself horrifies me in a production environment.
--
Greg Smith 2ndQuadrant US Baltimore, MD
PostgreSQL Training, Services and Support
greg@2ndQuadrant.com www.2ndQuadrant.us
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: greg@2ndquadrant.com, tgl@sss.pgh.pa.us, bricklen@gmail.com, pgsql-general@postgresql.org
Subject: Re: Archiver not picking up changes to archive_command
In-Reply-To: <4BE8AEE0.7080701@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox