pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Joachim Wieland <joe@mcknight.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: José Arthur Benetasso Villanova <jose.arthur@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: directory archive format for pg_dump
Date: Fri, 03 Dec 2010 11:22:53 +0200
Message-ID: <4CF8B6ED.3090300@enterprisedb.com> (raw)
In-Reply-To: <1291324036-sup-7776@alvh.no-ip.org>
References: <AANLkTi=AEi3F6jC0Zy3dG9njiwJJC8Y6V090-hMonyyn@mail.gmail.com>
	<AANLkTik+PR2HCsqS7PVAdETPyKSGn2hb-eTeg9QZpRew@mail.gmail.com>
	<4CEA9F29.5060106@enterprisedb.com>
	<28890.1290445623@sss.pgh.pa.us>
	<4CEAD61A.6060207@enterprisedb.com>
	<AANLkTi=neaBqvLa2ZnDpuAMSen3P4ZHE8__Q7L2pmjD0@mail.gmail.com>
	<4CF40B5F.1010407@enterprisedb.com>
	<4CF655A3.4090308@enterprisedb.com>
	<4CF6562E.60506@enterprisedb.com>
	<AANLkTinauQsCGt-yeyeN_QWuN+tao+q126rwKnO2QWLP@mail.gmail.com>
	<4CF74F99.4050008@enterprisedb.com>
	<4CF7F8FB.1040305@enterprisedb.com>
	<1291324036-sup-7776@alvh.no-ip.org>

On 02.12.2010 23:12, Alvaro Herrera wrote:
> Excerpts from Heikki Linnakangas's message of jue dic 02 16:52:27 -0300 2010:
>> Ok, committed, with some small cleanup since the last patch I posted.
>
> I think the comments on _ReadBuf and friends need to be updated, since
> they are not just for headers and TOC stuff anymore.  I'm not sure if
> they were already outdated before your patch ...

"These routines are only used to read & write headers & TOC"

Hmm, ReadInt calls _ReadByte, and PrintData used to call ReadInt, so it 
was indirectly been called for things other than headers and TOC 
already. Unless you consider the "headers" to include length integer in 
in each data block. I'm inclined to just remove that sentence.

I also note that the _Clone and _DeClone functions are a bit misplaced. 
There's a big "END OF FORMAT CALLBACKS" earlier in the file, but _Clone 
and _DeClone are such callbacks. I'll move them to the right place.

PS. Thanks for the cleanup you did yesterday.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com



view thread (40+ messages)  latest in thread

Message-ID: <4CF8B6ED.3090300@enterprisedb.com>
Permalink:  ../4CF8B6ED.3090300@enterprisedb.com/
Also on:    postgresql.org/message-id/4CF8B6ED.3090300@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: heikki.linnakangas@enterprisedb.com, alvherre@commandprompt.com, joe@mcknight.de, tgl@sss.pgh.pa.us, jose.arthur@gmail.com
  Subject: Re: directory archive format for pg_dump
  In-Reply-To: <4CF8B6ED.3090300@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox