From: Andrew Dunstan <andrew@dunslane.net>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: code cleanups
Date: Sat, 23 Apr 2011 19:03:23 -0400
Message-ID: <4DB35ABB.9010904@dunslane.net> (raw)
getopt.c is looking a bit ancient. In particular, getopt() has no
prototype and old style arguments. Is there any reason not to bring this
into the 1990s (or is that 1980s?)
gcc also doesn't like the way perl does unused attributes on Windows,
and it generates quite a few warnings about it. A little experimentation
suggests this would probably clean it up if placed at the start of plperl.h:
#if defined(__GNUC_)
#define PERL_UNUSED_DECL __attribute__ ((unused))
#endif
Thoughts?
cheers
andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net
Subject: Re: code cleanups
In-Reply-To: <4DB35ABB.9010904@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox