From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: drkp@csail.mit.edu
Cc: pgsql-hackers@postgresql.org
Subject: Re: SSI modularity questions
Date: Wed, 29 Jun 2011 22:18:00 +0300
Message-ID: <4E0B7A68.5030102@enterprisedb.com> (raw)
In-Reply-To: <4E0A0240020000250003ECDA@gw.wicourts.gov>
References: <4E0A0240020000250003ECDA@gw.wicourts.gov>
On 29.06.2011 00:33, Kevin Grittner wrote:
> Heikki Linnakangas wrote:
>> On 28.06.2011 20:47, Kevin Grittner wrote:
>
>> Hmm, the calls in question are the ones in heapgettup() and
>> heapgettup_pagemode(), which are subroutines of heap_getnext().
>> heap_getnext() is only used in sequential scans, so it seems safe
>> to remove those calls.
>
> I haven't found anything to the contrary, if I understand correctly,
> Dan found the same, and all the tests pass without them. Here's a
> patch to remove them. This makes the recently-added
> rs_relpredicatelocked boolean field unnecessary, so that's removed in
> this patch, too.
Thanks, committed. I also moved the PredicateLockRelation() call to
heap_beginscan(), per earlier discussion.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, Kevin.Grittner@wicourts.gov, drkp@csail.mit.edu
Subject: Re: SSI modularity questions
In-Reply-To: <4E0B7A68.5030102@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox