From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
To: Kevin Grittner <Kevin.Grittner@wicourts.gov>
Cc: drkp@csail.mit.edu
Cc: pgsql-hackers@postgresql.org
Subject: Re: Repeated PredicateLockRelation calls during seqscan
Date: Wed, 29 Jun 2011 22:19:11 +0300
Message-ID: <4E0B7AAF.10903@enterprisedb.com> (raw)
In-Reply-To: <4E07550F020000250003EC42@gw.wicourts.gov>
References: <4E07550F020000250003EC42@gw.wicourts.gov>
On 26.06.2011 23:49, Kevin Grittner wrote:
> "Kevin Grittner" wrote:
>> "Kevin Grittner" wrote:
>>> Heikki Linnakangas wrote:
>
>>>> BTW, isn't bitgetpage() in nodeBitmapHeapscan.c missing
>>>> PredicateLockTuple() and CheckForSerializableConflictOut() calls
>>>> in the codepath for a lossy bitmap? In the non-lossy case,
>>>> heap_hot_search_buffer() takes care of it, but not in the lossy
>>>> case.
>>>
>>> I think the attached addresses that.
>>
>> Don't commit that patch, it's not holding up in testing here.
>>
>> I'll look at it some more.
>
> Version 2 is attached.
Thanks, applied this too.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: heikki.linnakangas@enterprisedb.com, Kevin.Grittner@wicourts.gov, drkp@csail.mit.edu
Subject: Re: Repeated PredicateLockRelation calls during seqscan
In-Reply-To: <4E0B7AAF.10903@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox